Git Project: Reviewed Pull Request

Take a change through issue, branch, pull request, review comments, and merge so the GitHub conversation matches the Git graph.

Project brief

Unit 5 taught the pieces separately: GitHub Issues, GitHub Pull Requests, GitHub Code Review, a branching model, protection, templates, and contributing habits. This project runs them in order on a repository you own so the GitHub conversation and the Git graph are the same story.

Safety boundary

Repository contract

reviewed-pull-request/
└── clone-card/            ← one working copy of a GitHub repository YOU own

GitHub repository (origin): sovrancode-reviewed-pr
This is not a second clone of Two Clone Sync. Stay on a feature branch after the first README.

Git records the branch and the commits. GitHub stores the issue, the pull request, and the review comments. git show will not print the request-changes body. Both layers are required evidence.

Required conversation and graphs

*   Merge pull request #1 (HEAD -> main, origin/main)
|\
| * Use the GitHub Git URL in the Clone section
| * Document how to clone this repository
|/
* Initialize clone card

* Document how to clone this repository (HEAD -> main, origin/main)
* Initialize clone card

Pick one GitHub merge flag: gh pr merge 1 --merge, gh pr merge 1 --squash, or gh pr merge 1 --rebase. Draw the graph you expect before you merge. Rebase-merge is linear like squash but keeps the feature commit messages; name that if you choose it.

Milestone 1 · Host the clone card

Create the parent folder, initialize only clone-card, commit the README contract, then publish an empty GitHub repository you own. Record the first commit ID. There is no Clone heading yet.

mkdir -p reviewed-pull-request/clone-card
cd reviewed-pull-request/clone-card
git init -b main
git status

# Write README.md from the contract below, then:
git add README.md
git diff --cached
git commit -m "Initialize clone card"
git status
git rev-parse HEAD

git rev-parse --show-toplevel
gh auth status
gh repo create sovrancode-reviewed-pr --public --source=. --remote=origin --push

git remote -v
git branch -vv
git ls-remote origin
git rev-parse HEAD

# Clone card

A tiny README that must tell a stranger how to clone this GitHub repository.

## Status

The Clone heading is missing. File an issue, then add it on a feature branch.

Replace OWNER later with your GitHub username. Omit any gh repo create flag that adds a README. If you used the website instead, add origin yourself, then run git push -u origin main. Proof: git ls-remote origin lists the same object as git rev-parse HEAD.

Milestone 2 · File the issue

Stay on main. Open one GitHub issue before you branch. Use the headings GitHub Issues required. If this repository already has a bug template from Collaboration, use it and fill every heading.

gh issue create --title "Clone command is missing or is a Pages URL" --body "$(cat <<'EOF'
## Problem
The README has no Clone heading a stranger can copy, or the command is a GitHub Pages URL.

## Expected result
README.md has a Clone heading whose command is this repository's GitHub Git URL (HTTPS or SSH). A stranger who pastes it can run git clone.

## Reproduction
1. Open README.md on main.
2. Confirm there is no working git clone command, or that the command uses a .github.io host.
3. Note that a Pages URL is a static site, not a Git remote.
EOF
)"
gh issue list
gh issue view 1

## Problem
The README has no Clone heading a stranger can copy, or the command is a GitHub Pages URL.

## Expected result
README.md has a Clone heading whose command is this repository's GitHub Git URL (HTTPS or SSH). A stranger who pastes it can run git clone.

## Reproduction
1. Open README.md on main.
2. Confirm there is no working git clone command, or that the command uses a .github.io host.
3. Note that a Pages URL is a static site, not a Git remote.

Proof: issue #1 exists on this repository, not on a project you do not maintain. Do not start coding until the issue is filed. The pull request will close this number; if you file two issues, Closes #1 must still name the clone defect.

Milestone 3 · Branch with a planted defect

Create feature/clone-url from current main. Add a Clone heading that uses a GitHub Pages URL on purpose. That defect is the review target. Commit and push the branch. Do not merge yet.

git switch main
git pull origin main
git switch -c feature/clone-url

# Append the planted Clone heading to README.md, then:
git add README.md
git diff --cached
git commit -m "Document how to clone this repository"
git push -u origin feature/clone-url
git branch -vv
git diff main...HEAD --stat

## Clone

git clone https://OWNER.github.io/sovrancode-reviewed-pr/

Replace OWNER with your username so the Pages host looks plausible. The command must still be wrong: .github.io is a static site host, not a Git remote. git diff main...HEAD --stat must list only README.md.

Milestone 4 · Open the pull request

Open a GitHub pull request from feature/clone-url into main. This is GitHub, not git pull. Fill summary, verify steps, and Closes #1. If a pull request template exists, use it; do not leave Closes # without a number.

gh pr create --base main --title "Document how to clone this repository" --body "$(cat <<'EOF'
## Summary
Adds a Clone heading so a stranger can copy the GitHub Git URL.

## Linked issue
Closes #1

## How to verify
1. Open README.md on this branch.
2. Confirm the clone command uses the GitHub Git URL, not a Pages URL.
3. Confirm no other files changed.
EOF
)"
gh pr list
gh pr view 1
gh pr diff 1

## Summary
Adds a Clone heading so a stranger can copy the GitHub Git URL.

## Linked issue
Closes #1

## How to verify
1. Open README.md on this branch.
2. Confirm the clone command uses the GitHub Git URL, not a Pages URL.
3. Confirm no other files changed.

Proof: gh pr view 1 shows the issue link and the branch name. gh pr diff 1 still contains the Pages URL. If GitHub says the pull request can be merged, that is not review. You have only proposed.

Milestone 5 · Request changes

You are the reviewer now. On GitHub, Files changed, leave a line comment on the clone command. Then submit an overall verdict. Review comments are GitHub conversation data, not Git objects.

gh pr diff 1
gh pr view 1 --comments

gh pr review 1 --request-changes --body "$(cat <<'EOF'
The Clone section still uses a Pages URL.

That address is a static site host, not a Git remote. A stranger who copies it cannot git clone this repository.

Please change the command to the GitHub Git URL, then push the fix to this same branch.
EOF
)"

Proof: gh pr view 1 --comments includes the request. Approving now fails the project. Do not merge. Do not open a second pull request.

Milestone 6 · Answer with an ordinary push

Stay on feature/clone-url. Replace the Pages URL with the GitHub Git URL. Commit and git push. Do not force-push. Reviewers already have the first commit.

# Stay on feature/clone-url. Do not switch to main.
# Edit README.md so git clone uses the GitHub Git URL, then:
git add README.md
git diff --cached
git commit -m "Use the GitHub Git URL in the Clone section"
git push
gh pr view 1 --comments
gh pr diff 1

# These rewrite history reviewers already read. Do not run them:
# git push --force
# git push --force-with-lease

## Clone

git clone https://github.com/OWNER/sovrancode-reviewed-pr.git

HTTPS or SSH is fine if it is this repository's Git remote. Proof: gh pr diff 1 no longer contains .github.io, and the pull request still has two feature commits (unless you already chose squash-only locally—which you must not; leave both commits on the branch).

Milestone 7 · Merge and prove the graph

Approve, then merge with one flag you can justify. Update local main from origin. Delete the feature branch locally and on the remote. Confirm the issue closed.

gh pr review 1 --approve --body "Clone command now uses the GitHub Git URL. Verified on this branch."

# Pick ONE. Draw the graph before you run it.
gh pr merge 1 --merge
# gh pr merge 1 --squash
# gh pr merge 1 --rebase

git fetch origin
git switch main
git pull origin main
git log --oneline --decorate --graph -n 12
git rev-parse HEAD
git ls-remote origin refs/heads/main

git branch -d feature/clone-url
git push origin --delete feature/clone-url
git branch -vv

gh pr view 1
gh issue view 1

If GitHub Branch Protection already refuses git push origin main, that is expected: the pull request was the legal path. Do not turn on two-reviewer lockout on a solo repo. Required Actions checks are GitHub Actions.

Proof: git rev-parse HEAD equals the object from git ls-remote origin refs/heads/main. gh issue view 1 is closed. The log matches the flag you chose. Status is clean.

git rev-parse --show-toplevel
git remote -v
git status
git fetch origin
git switch main
git pull origin main
git log --oneline --decorate --graph -n 12
git branch -vv
git rev-parse HEAD
git ls-remote origin refs/heads/main
gh pr view 1
gh pr view 1 --comments
gh issue view 1

Required failure drills

Evidence package

• Path from git rev-parse --show-toplevel and git remote -v for the GitHub repository you own.
• Issue #1 body with problem, expected result, and reproduction.
• gh pr view 1 and gh pr diff 1 from before the fix, showing the Pages URL.
• Request-changes body and the follow-up commit ID from git log --oneline main..HEAD (or the equivalent range before you deleted the branch).
• The merge flag you chose, a sketch of the graph, and git log --oneline --decorate --graph -n 12 after pull.
• Matching SHAs from git rev-parse HEAD and git ls-remote origin refs/heads/main, plus gh issue view 1 showing closed.

Self-assessment rubric: 25 points

Project checklist

• I filed one complete GitHub issue on a repository I own, then branched.
• I opened one pull request with Closes #1 and a planted Pages URL for review to catch.
• I requested changes, then answered with git push on the same branch, not force-push.
• I merged with a flag whose graph I can name, updated local main, and closed the issue through GitHub.
• I never used a popular project as the lab or treated git pull as the pull request.

Final audit commands

git rev-parse --show-toplevel
git remote -v
git status
git fetch origin
git switch main
git pull origin main
git log --oneline --decorate --graph -n 12
git branch -vv
git rev-parse HEAD
git ls-remote origin refs/heads/main
gh pr view 1
gh pr view 1 --comments
gh issue view 1

Those commands answer one question: does the GitHub conversation (issue, review, merge) describe the same history as local main and origin/main? When they do, the unit project is complete. A check reviewers can trust is GitHub Actions.